Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off CI testing on nightly #47

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Turn off CI testing on nightly #47

merged 1 commit into from
Jul 16, 2024

Conversation

abhro
Copy link
Member

@abhro abhro commented Jul 16, 2024

No description provided.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (d829131) to head (da02d28).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          10       10           
  Lines         262      262           
=======================================
  Hits          261      261           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhro
Copy link
Member Author

abhro commented Jul 16, 2024

Better option would be to keep testing and allow failures, but that's a more involved change. Currently testing on nightly clutters up the CI for all other PRs and commits. A future PR can re-add testing on nightly with failures allowed.

@abhro abhro merged commit e3a55c5 into master Jul 16, 2024
9 of 11 checks passed
@abhro abhro deleted the disable-nightly-ci branch July 16, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant